[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 3983 - in trunk: . subversion/include subversion/libsvn_ra_svn subversion/svnserve

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2002-12-04 07:59:11 CET

Thanks. A few small complaints:

On Wed, 2002-12-04 at 01:09, brane@tigris.org wrote:
> -- "log" happens to be a standard C function; for consistency all
> the svnserve vtable function names got a prefix.

I had a convention for this, which was to add "_cmd" to just the symbols
which had conflicts. (switch_cmd was the only one so far.) Calling
them ra_svn_foo means the server functions have the same names as the
client functions, which can be inconvenient when setting breakpoints.

> -static svn_error_t *get_latest_rev(svn_ra_svn_conn_t *conn, apr_pool_t *pool,
> - apr_array_header_t *params, void *baton)
> +static svn_error_t *
> +ra_svn_get_latest_rev(svn_ra_svn_conn_t *conn, apr_pool_t *pool,
> + apr_array_header_t *params, void *baton)

Unless we have a tree-wide style policy on this point, I'd prefer if you
wouldn't reformat these function declarations.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 4 08:04:10 2002

This is an archived mail posted to the Subversion Dev mailing list.