[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_path_is_url()

From: David Mankin <mankin_at_ants.com>
Date: 2002-11-26 17:40:54 CET

On Tuesday, November 26, 2002, at 07:56 AM, Karl Fogel wrote:

> David Mankin <mankin@ants.com> writes:
>> The comment in svn_path.h isn't any more help; it appears to be just
>> plain wrong:
>> /* Compare PATH to an array of const char * URL SCHEMES (like "file",
>> "http", etc.) to determine if PATH looks like a URL. If so,
>> return
>> the matching scheme used by PATH, else return NULL. Returned
>> values point to the allocations in SCHEMES. */
>> svn_boolean_t svn_path_is_url (const char *path);
>
> That comment is pretty confusing yeah. It shouldn't talk about the
> internal implementation, just say that it returns true iff PATH is a
> url in a known scheme.

Beyond that, the implementation just looks for :// with no : or /
before it, it doesn't even check any list of schemes at all! Should it
be changed to match the docstring, or should the docstring be changed
to match the function?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 26 17:42:16 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.