>
>
>You patch has some really separable parts (and some parts that
>probably didn't need to change at all). I'd like, for example, to see
>a patch that strictly covers the renaming of the bdb/*.c functions to
>have "svn_fs__bdb" prefixes. I like that change, I should have done
>it myself when I did the re-org a while back.
>
>On the other hand, I *don't* like the renaming of 'revision_root' and
>'transaction_root' to 'kind_revision_root' and 'kind_transaction_root'
>-- just unnecessary mods outright.
>
Mike with the ol laser vision:-)
I seem to remember that change being related to some greping I was
doing. I'll make it go away.
I'll make a mail folder to collect these type of things in until I get
back in gear. The Garrett pointed out was a major boo boo also.
>
>
>>Mike you poor sick puppy:-) Did you get the short straw?
>>
>>
>
>No, I offered to do this since I've been a really vocal opponent
>(mostly off-list) of us just giving you a branch. It was an uphill
>fight against Ben and Karl (not really), and my offer was a way of
>staking a personal connection to this process. I *do* like what I've
>seen of your proposal, I *do* think (especially having met you in
>person) that competence won't be a concern. But I want our processes
>to be beneficial to everyone *and* produce reviewable, excellent code
>changes.
>
>
Well thanks.
>
>Nah...just isn't a good thing...
>
>
>
Heh. Got it.
I'm going to go off-line now guys. Those dang bills:-)
gat
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 22 20:41:41 2002