Re: [PATCH] Corrected successful return value of mod_dav_svn's dav_svn__update_report()

Karl Fogel <kfogel@newton.ch.collab.net> writes:

> Daniel Rall <dlr@finemaltcoding.com> writes:
> > * subversion/mod_dav_svn/update.c
> >
> > (dav_svn__update_report): The return type of the function is
> > dav_error *, not svn_error_t *. SVN_NO_ERROR is not a dav_error *,
> > so return NULL rather than SVN_NO_ERROR when there is no error. The
> > old implementation works, but the new is both more correct and
> > consistent.
>
> Nice catch! Want to just commit it yourself?
>
> -K
>
> > Index: subversion/mod_dav_svn/update.c
> > ===================================================================
> > --- subversion/mod_dav_svn/update.c (revision 3802)
> > +++ subversion/mod_dav_svn/update.c (working copy)
> > @@ -827,5 +827,5 @@
> > "report.");
> > }
> >
> > - return SVN_NO_ERROR;
> > + return NULL;
> > }

Committed as revision 3805.

-- 
Daniel Rall <dlr@finemaltcoding.com>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org