[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Corrected successful return value of mod_dav_svn's dav_svn__update_report()

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-11-15 20:59:19 CET

Daniel Rall <dlr@finemaltcoding.com> writes:
> * subversion/mod_dav_svn/update.c
>
> (dav_svn__update_report): The return type of the function is
> dav_error *, not svn_error_t *. SVN_NO_ERROR is not a dav_error *,
> so return NULL rather than SVN_NO_ERROR when there is no error. The
> old implementation works, but the new is both more correct and
> consistent.

Nice catch! Want to just commit it yourself?

-K

> Index: subversion/mod_dav_svn/update.c
> ===================================================================
> --- subversion/mod_dav_svn/update.c (revision 3802)
> +++ subversion/mod_dav_svn/update.c (working copy)
> @@ -827,5 +827,5 @@
> "report.");
> }
>
> - return SVN_NO_ERROR;
> + return NULL;
> }
>
> --
>
> Daniel Rall <dlr@finemaltcoding.com>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 15 21:34:11 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.