Re: svn status: does not notice changed file if timestamp of "new" file is older

Philip Martin <philip@codematters.co.uk> writes:

> I wonder if svn_io_file_affected_time() should simply return the mtime
> on Windows? This may be the correct behavior on Unix as well, I'm not
> sure the docstring's argument about tracking permissions is correct,
> which bit of Subversion needs to know that they changed?

Well, we don't appear to have any regression tests that rely on the
ctime behaviour, on Unix they pass with this patch applied

Index: subversion/libsvn_subr/io.c
===================================================================
--- subversion/libsvn_subr/io.c (revision 3763)
+++ subversion/libsvn_subr/io.c (working copy)
@@ -510,10 +510,7 @@
 
   SVN_ERR (svn_io_stat (&finfo, path, APR_FINFO_MIN, pool));
 
- if (finfo.mtime > finfo.ctime)
- *apr_time = finfo.mtime;
- else
- *apr_time = finfo.ctime;
+ *apr_time = finfo.mtime;
 
   return SVN_NO_ERROR;
 }

I don't think Subversion needs to know the ctime of a working copy
file. The mtime is what is needed to track text changes, and property
changes are tracked via the the mtime of the property file.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org