[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Regression in utf-8 log message support?

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-11-11 21:17:17 CET

Try going to

   http://svn.collab.net/scripts/tweak-log.cgi

and entering `2608' as the revision number (you may need commit access
for this). The revision's log message shows up as empty. If you do a
View Source, you'll see no log message data there at all! At least,
that's what happens to me with Mozilla. Does it happen for anyone
else?

2608 is one of the few revisions with 8-bit UTF-8 characters in it
(Brane's family name, actually). You can see it with

I just discovered this when I tried to tweak a recent log message:

   $ cat new-msg.txt
   * HACKING: Mention the need to call apr_initialize() first.
   Thanks to Steve Küng (ichselbst@gmx.ch) for the suggestion.
   $ svn propset --revprop -r 3728 -F new-msg.txt svn:log

Then when I checked the new log message in my browser, at the above
URL, it was empty.

However, I was able to use this command

   $ svn propget --revprop -r 3728 svn:log

to see the message, although the umlaut came out garbled (odd, as I
thought I had an 8859-1 system). On the other hand, when I tried the
same thing for Brane's revision, I got an error:

   $ svn propget --revprop -r 2608 svn:log
   Unversioned properties on revision 2608:
   subversion/libsvn_subr/utf.c:168: (apr_err=22, src_err=0)
   svn: Invalid argument
   svn: failure during string recoding
   $

I'm not sure what to think about that. On the one hand, Brane's
family name doesn't code in 8859-1. On the other hand, we have
graceful degradation for 'svn log', so at least the rest of the bytes
are visible, and probably we should do that when fetching the
`svn:log' property too.

Anyway, regarding the fact that *neither* message shows up in
tweak-log.cgi: an ethereal trace shows that the data is truly not
there, so the problem is that the server is not even sending it:

Request:
========

   POST /scripts/tweak-log.cgi HTTP/1.1
   Host: svn.collab.net
   User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.1b) Gecko/20020722
   Accept: text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,video/x-mng,image/png,image/jpeg,image/gif;q=0.2,text/css,*/*;q=0.1
   Accept-Language: en-us, en;q=0.50
   Accept-Encoding: gzip, deflate, compress;q=0.9
   Accept-Charset: ISO-8859-1, utf-8;q=0.66, *;q=0.66
   Keep-Alive: 300
   Connection: keep-alive
   Authorization: Basic a2ZvZ2VsOnRoZTE3MjlrZXk=
   Referer: http://svn.collab.net/scripts/tweak-log.cgi
   Content-Type: application/x-www-form-urlencoded
   Content-Length: 25
   
   rev=2608&action=Fetch+Log

Response:
=========

   HTTP/1.1 200 OK
   Date: Mon, 11 Nov 2002 20:20:53 GMT
   Server: Apache/2.0.44-dev (Unix) mod_ssl/2.0.44-dev OpenSSL/0.9.6 DAV/2 SVN/0.14.5 (dev build)
   Content-Length: 704
   Keep-Alive: timeout=15, max=100
   Connection: Keep-Alive
   Content-Type: text/html; charset=UTF-8
   
   <html>
   <head>
   <title>Tweak Log - Log Edit</title>
   </head>
   <body>
   <h1>Editing Log Message for Revision 2608</h1>
   <h2>Current log message:</h2>
   <blockquote><hr /><pre></pre><hr /></blockquote>
   
   <p>
   <font color="red">
   <i>Every change made is logged in <tt>./TWEAKLOG</tt> in
   the directory this cgi script runs in. If you make a bogus
   change, you can still recover the old message from there.</i>
   </font>
   
   <p>
   <form action="./tweak-log.cgi" method="post">
   <h2>New log message:</h2>
   <blockquote>
   <textarea cols="80" rows="25" wrap="off" name="log">
   </textarea><br />
   <input type="hidden" name="rev" value="2608">
   <input type="submit" name="action" value="Commit Changes">
   </blockquote>
   </form></body></html>

Whew. Buncha problems here. Any thoughts before I file some issues?

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 11 21:51:04 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.