[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix issue #976

From: Blair Zajac <blair_at_orcaware.com>
Date: 2002-11-11 20:32:46 CET

Karl Fogel wrote:
>
> Blair Zajac <blair@orcaware.com> writes:
> > Can somebody review this small patch? Especially the python test,
> > which I haven't gotten to work.
>
> Looks great to me.
>
> Did you try Brane's solution for the regression test yet? He
> recommended using
>
> expected_disk.add({'new_file2.bin' :
> Item(props={'svn:mime-type' : orig_mime_type})})
>
> in the obvious spot. I haven't tried it, but it ought to work.
>
> Assume you'll commit this if it all works. Do post if have any
> problems, there's no reason we can't get this issue klonked today :-).

Well, it turns out that
   svntest.main.actions.run_and_verify_commit
doesn't take an expected_disk argument, so I need to find another
way to check the properties on the file after an svn cp.

I could do the commit and then use
    svntest.actions.run_and_verify_update
which would be an empty update to check the properties.

What's the best way to do this.

BTW, should run_and_verify_commit be modified to take an expected
disk structure?

Blair

-- 
Blair Zajac <blair@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 11 20:33:28 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.