[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 3701 - trunk/subversion/libsvn_subr

From: Justin Erenkrantz <jerenkrantz_at_apache.org>
Date: 2002-11-09 11:19:10 CET

--On Saturday, November 9, 2002 12:20 AM -0600 Karl Fogel
<kfogel@newton.ch.collab.net> wrote:

> If the solution is fast, can you post a patch?
>
> If not, no big deal, we can live with the old (pre-3701) lossage
> for a little bit longer. It's not like it suddenly became more
> severe by being discovered :-).
>
> (I'm not coding right now, I'm just able to check email at irregular
> intervals, or I'd try the patch myself. As you can see, I haven't
> even had time to revert and file the issue yet, so if you patch it
> fast, maybe you'll beat me to it?)

Since I can't reproduce this problem with any iconv() libraries I
have access to, I would ask if you guys can try this patch out. (It
compiles and passes the basic_tests.py here, but it did before
anyway.)

This patch removes the use of adm_access->pool in the
svn_wc__adm_is_cleanup_required and do_close call in the pool cleanup
case within libsvn_wc/log.c.

I would wonder if this just causes us to find other places that are
similarly bogus. -- justin

P.S. Hopefully, my mailer doesn't munge this patch. If it seems that
it does, I'll resend...

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Sat Nov 9 11:19:40 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.