Re: svn commit: rev 3701 - trunk/subversion/libsvn_subr

Justin Erenkrantz <jerenkrantz@apache.org> writes:
> Nope, I can't reproduce on Solaris, either. Well, that is that 'make
> check' passes for basic_tests.py (up to prop_tests.py with success).

It's pretty clearly a GNU/Linux iconv() thing, since the same problem
is causing Brane's automated tests to break (see the mails to the
`breakage' list).

> The reason reverting the patch works is that the iconv buffer isn't
> coming from that pool, but instead from the global pool (which is
> never cleaned up). I bet that on Solaris and Darwin, the iconv()
> buffers are stateless (i.e. a close does nothing), or the pool_cleanup
> is called before the iconv_close cleanup.
>
> You can't have any dependencies between pool cleanups. Either that
> pool passed to svn_wc__adm_is_cleanup_required must be that pool's
> parent (perhaps easiest), or pool_cleanup must go away. Regardless,
> r3701 isn't at fault. It just indicated the faulty logic here. =)

Okay. I'll have a look, thanks.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Nov 9 03:31:48 2002