Re: svn commit: rev 3701 - trunk/subversion/libsvn_subr

--On Friday, November 08, 2002 16:40:50 -0600 Karl Fogel
<kfogel@newton.ch.collab.net> wrote:

> Hey Justin, did you run 'make check' on this?

Yeah, I waited for about an hour while the tests ran. So, it did pass all
tests with flying colors for me on Darwin. I wouldn't have checked it in
otherwise.

> This test
>
> $ cd subversion/tests/clients/cmdline
> $ ./basic_tests 11 BASE_URL=http://localhost
>
> seems to be failing now. In the Python, this call to 'svn rm' seg
> faults:

Hmm. I'll try to reproduce this on Solaris, as I'm not near my Darwin box,
it'll take me a bit to get it up to where I can test it. (It's not
recognizing my libtool install right now.)

It's very possible that there are bad iconv() implementations flying around.
As I don't have a Linux box, I can't test with that iconv() implementation.

> Do you think we should revert 3701 while we find a different fix for
> the original problem 3701 was meant to solve, or is the Right Solution
> here immediately obvious to you? (It's not to me, but then, it's been
> a while since I looked at the i18n code.)

No. r3701 is the correct solution. Nothing else makes any sense. What we
had before was just blantantly wrong. The only thing I can think of is
that there might be an iconv() library that isn't thread-safe and doesn't
support multiple open buffers. But, that'd be a flaw in the iconv()
implementation not the core iconv() API (as it worked on Darwin).

Regardless, I'm trying to reproduce here. -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Nov 9 00:43:06 2002