Re: patch suggestion

On Tue, Nov 05, 2002 at 08:27:36PM +0100, Branko Cibej wrote:
>...
> context param would be expensive. Later on I suggested storing the
> context in the top-level pool (which would be different for each client
> thread), but there haven't been any replies yet. Serves me right for
> pushing comments into the issue tracker instead of posting them here.
> But maybe I should just implement that...

We should avoid using pools as a way to store global variables, or even
per-thread variables. That is just ugly. The old callback system worked that
way, and hoo boy, was it confusing. I recall a problem with it and
explaining that to Ben and how it interacted with that callback stuff; even
though he had helped to work on the callbacks, he was flabbergasted. Had no
idea how that particular interaction occurred. At that point, he was a True
Convert to get rid of that pool hackiness.

And no, don't point out that the error pool stuff are effectively globals in
the pools, as that is still all about pool management. Not storage of state.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org