ghudson@tigris.org wrote:
>author: ghudson
>Date: 2002-10-22 15:06:54 -0500 (Tue, 22 Oct 2002)
>New Revision: 3441
>
>Modified:
> trunk/subversion/libsvn_subr/svn_error.c
>Log:
>Add to the FIXME comment with a different plan which doesn't
>require locking.
>
>
>Modified: trunk/subversion/libsvn_subr/svn_error.c
>==============================================================================
>--- trunk/subversion/libsvn_subr/svn_error.c (original)
>+++ trunk/subversion/libsvn_subr/svn_error.c Tue Oct 22 15:06:56 2002
>@@ -56,6 +56,10 @@
> /* XXX FIXME: These should be protected by a thread mutex.
> svn_error__locate and make_error_internal should cooperate
> in locking and unlocking it. */
>+/* There's no need for global data here. Just pass __FILE__ and
>+ __LINE__ to the true names of svn_error_create() and friends. To
>+ avoid having two variants each of three functions, always record
>+ file and line information; there's no reason not to. --ghudson */
>
>
Hm. Someone remind me why I didn't do it this way in the first place.
--
Brane Čibej <brane_at_xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 22 23:29:37 2002