Branko Čibej wrote:
>> Modified: trunk/subversion/libsvn_subr/svn_error.c
>> ==============================================================================
>>
>> --- trunk/subversion/libsvn_subr/svn_error.c (original)
>> +++ trunk/subversion/libsvn_subr/svn_error.c Tue Oct 22 15:06:56 2002
>> @@ -56,6 +56,10 @@
>> /* XXX FIXME: These should be protected by a thread mutex.
>> svn_error__locate and make_error_internal should cooperate
>> in locking and unlocking it. */
>> +/* There's no need for global data here. Just pass __FILE__ and
>> + __LINE__ to the true names of svn_error_create() and friends. To
>> + avoid having two variants each of three functions, always record
>> + file and line information; there's no reason not to. --ghudson */
>>
>>
> Hm. Someone remind me why I didn't do it this way in the first place.
I'll go ahead and remind myself: If somebody can wrap svn_error_createf
this way, without using C99-style varargs macros and without requiring
people to pass in __FILE__ and __LINE__ explicitly, I'll make pennance
by not touching the compurer for three consecutive working days. In the
meantime, I stand by my implementation.
--
Brane Čibej <brane_at_xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 24 23:00:25 2002