Re: svn commit: rev 3441 - trunk/subversion/libsvn_subr

On Tue, Oct 22, 2002 at 11:28:52PM +0200, Branko Cibej wrote:
> ghudson@tigris.org wrote:
>...
> >+/* There's no need for global data here. Just pass __FILE__ and
> >+ __LINE__ to the true names of svn_error_create() and friends. To
> >+ avoid having two variants each of three functions, always record
> >+ file and line information; there's no reason not to. --ghudson */
>
> Hm. Someone remind me why I didn't do it this way in the first place.

Maybe because if the compiler does not fold string constants, that you will
seriously bulk up the files? [even in the non-debug case]

If it was for perf reasons (avoid the two params!), and I said that, then
feel free to slap me at ApacheCon :-)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org