[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 3110 - trunk/subversion/include

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-09-02 04:44:01 CEST

On Sun, Sep 01, 2002 at 01:29:41PM -0500, Karl Fogel wrote:
> Branko Cibej <brane@xbc.nu> writes:
> > >I don't understand why they can't aggregate an svn_delta_editor_t with a
> > >void * themselves. Why are we polluting our structures?
> >
> > I concur. -1 on putting stuff that we don't need into our structures,
> > they're verbose enough as it is. Especially as there's no compelling
> > need for that.
>
> I was also confused as to the need for this change. Subversion itself
> can't possibly use that void *ctx, so Greg Hudson's suggestion that
> the caller aggregate svn_delta_editor_t with whatever other data they
> need seems the way to go... But would like to hear more from Greg
> Stein about specific use cases before saying -1; maybe there's
> something tricky we're missing here. Greg?

I was a bit dubious doing it, and checking it in, too. But I also seem to
recall some pretty compelling arguments for it.

I'll follow up with Gerald Richter (the person who suggested it), and
explain here, or back it out.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 2 04:39:06 2002

This is an archived mail posted to the Subversion Dev mailing list.