[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 3110 - trunk/subversion/include

From: Glenn A. Thompson <gthompson_at_cdr.net>
Date: 2002-09-01 18:17:32 CEST

Hey:

Greg Hudson wrote:

> On Sat, 2002-08-31 at 19:55, gstein@tigris.org wrote:
> > While as OSCON, I was talking with some people who want to embed SVN
> > in their program. In order to dynamically allocate some of the
> > structures, they need a context pointer to hold their private state
> > (e.g. the target of a thunking vtable layer). To help these people
> > out, we simply add a little context field to some of our structures.
> > Normally, this will be NULL (especially if the structure is statically
> > allocated constant data).
>
> I don't understand why they can't aggregate an svn_delta_editor_t with a
> void * themselves. Why are we polluting our structures?

Isn't user_data (tied to a context) usually provided as a formal parameter.
Then given back as a formal parameter. I don't think I've ever used an API
which wanted me to use it's opaque structures.

I know this changes the API but it's important enough to de-opaque-a-fy
Subversion structures. It's important enough to be declared formally in the
API.
I missed the original post so I'm not clear on which structures. So if I'm
all wet... Nevermind:-)

gat

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Sep 1 18:15:05 2002

This is an archived mail posted to the Subversion Dev mailing list.