[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 3110 - trunk/subversion/include

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-09-01 20:29:41 CEST

Branko Čibej <brane@xbc.nu> writes:
> >I don't understand why they can't aggregate an svn_delta_editor_t with a
> >void * themselves. Why are we polluting our structures?
>
> I concur. -1 on putting stuff that we don't need into our structures,
> they're verbose enough as it is. Especially as there's no compelling
> need for that.

I was also confused as to the need for this change. Subversion itself
can't possibly use that void *ctx, so Greg Hudson's suggestion that
the caller aggregate svn_delta_editor_t with whatever other data they
need seems the way to go... But would like to hear more from Greg
Stein about specific use cases before saying -1; maybe there's
something tricky we're missing here. Greg?

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Sep 1 20:50:34 2002

This is an archived mail posted to the Subversion Dev mailing list.