[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 3110 - trunk/subversion/include

From: Branko Čibej <brane_at_xbc.nu>
Date: 2002-09-01 18:00:04 CEST

Greg Hudson wrote:

>On Sat, 2002-08-31 at 19:55, gstein@tigris.org wrote:
>>While as OSCON, I was talking with some people who want to embed SVN
>>in their program. In order to dynamically allocate some of the
>>structures, they need a context pointer to hold their private state
>>(e.g. the target of a thunking vtable layer). To help these people
>>out, we simply add a little context field to some of our structures.
>>Normally, this will be NULL (especially if the structure is statically
>>allocated constant data).
>I don't understand why they can't aggregate an svn_delta_editor_t with a
>void * themselves. Why are we polluting our structures?

I concur. -1 on putting stuff that we don't need into our structures,
they're verbose enough as it is. Especially as there's no compelling
need for that.

Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Sep 1 18:00:43 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.