Re: svn commit: rev 3103 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_subr trunk/subversion/mod_dav_svn trunk/subversion/clients/cmdline

On Fri, Aug 30, 2002 at 03:01:13PM +0200, brane@xbc.nu wrote:
> > > +{
> > > + return (! ( (mime_type[0] == 't')
> > > + && (mime_type[1] == 'e')
> > > + && (mime_type[2] == 'x')
> > > + && (mime_type[3] == 't')
> > > + && (mime_type[4] == '/')));
> > > }
> >
> > Why not use strncmp? And, is mime_type guaranteed to have at least
> > 5 characters?
>
> If you use strncmp, you have to check the length first, because the mime type
> _could_ be shorter than 5 chars.

Why must you check the length first? strncmp won't overrun a NUL, it's
defined to compare "at most N" not "exactly N" bytes.

joe

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Aug 30 23:26:03 2002