Quoting Sander Striker <striker@apache.org>:
> > From: kfogel@tigris.org [mailto:kfogel@tigris.org]
> > Sent: 30 August 2002 08:51
>
> > Author: kfogel
> > Date: 2002-08-30 01:51:15 -0500 (Fri, 30 Aug 2002)
> > New Revision: 3103
>
> [...]
> > Modified: trunk/subversion/libsvn_subr/validate.c
> >
> ==============================================================================
> > --- trunk/subversion/libsvn_subr/validate.c (original)
> > +++ trunk/subversion/libsvn_subr/validate.c Fri Aug 30 01:51:19 2002
>
> > @@ -59,6 +59,17 @@
> > }
> >
> > return SVN_NO_ERROR;
> > +}
> > +
> > +
> > +svn_boolean_t
> > +svn_mime_type_is_binary (const char *mime_type)
> > +{
> > + return (! ( (mime_type[0] == 't')
> > + && (mime_type[1] == 'e')
> > + && (mime_type[2] == 'x')
> > + && (mime_type[3] == 't')
> > + && (mime_type[4] == '/')));
> > }
>
> Why not use strncmp? And, is mime_type guaranteed to have at least
> 5 characters?
If you use strncmp, you have to check the length first, because the mime type
_could_ be shorter than 5 chars. In this case, you can't miss because the first
unexpected char (e.g., a null) will short-circuit out of the condition.
But you know that, it's just that your vacation was too long. :-)
Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Aug 30 15:01:55 2002