[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 3091 - trunk/subversion/libsvn_wc

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-08-28 23:14:58 CEST

Philip Martin <philip@codematters.co.uk> writes:
> > SVN_ERR (svn_wc__wcprop_path (&wcprop_path, path, 0, subpool));
> > - (void) apr_file_remove (wcprop_path, subpool);
> > + (void) svn_io_remove_file (wcprop_path, subpool);
> An ignored error should go through svn_error_clear_all.


There are two such calls in the file now, so both should be fixed.
But also, reading the comment near the second call, I'm wondering if
maybe we should check that err->apr_err is something expected before
ignoring (clearing) the error, too...?

(I won't be taking care of this today, just fyi, so feel free if you

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Aug 28 23:34:45 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.