[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 3088 - trunk/subversion/libsvn_wc

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-08-28 18:09:18 CEST

philip@tigris.org writes:
> Log:
> Fix an unitialized memory read identified by valgrind.
>
> * subversion/libsvn_wc/questions.c (svn_wc_check_wc): Check error before format

Hmmm. That's interesting -- valgrind doesn't know enough to know that
that code was correct because of the semantics of the conditional's
body.

No objection to switching the order, if only for clarity, just
pointing out that there wasn't really a bug here :-).

-K

> Modified: trunk/subversion/libsvn_wc/questions.c
> ==============================================================================
> --- trunk/subversion/libsvn_wc/questions.c (original)
> +++ trunk/subversion/libsvn_wc/questions.c Wed Aug 28 06:34:46 2002
> @@ -67,7 +67,7 @@
>
> err = svn_io_read_version_file (wc_format, format_file_path, pool);
>
> - if ((*wc_format > SVN_WC__VERSION) || err)
> + if (err || (*wc_format > SVN_WC__VERSION))
> {
> /* It really doesn't matter if it was a version mismatch or
> an error, or if an error, what kind. If there's anything
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Aug 28 18:28:56 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.