[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn -R ... how to get it really into svn

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-08-25 22:56:51 CEST

solo turn <soloturn99@yahoo.com> writes:
> some time ago i proposed a patch to make svn -R recurse over all
> directories, and does not stop if a directory already exists.
> there were 2 small comments on it (like use .. != .. instead of !(..
> == ..)
> but for a reason i still don't understand, the patch made it to the
> mailing list, noone objecting to it, but also noone seemed to care to
> really apply it to the source tree.
> what do i have to do to get a patch into the source tree?

You have to wait for people to finish the 0.14.2 release process and
then get time to review pending patches, basically :-).

There's nothing wrong with posting a reminder, as you just did. But
don't worry, your patch is not lost. It's archived with about fifty
other patches, and we will get to them as soon as we can.

I've been (personally) planning a big patch review day for a week; it
got pushed due to some other stuff, right now it's scheduled for
Tuesday. I can't *promise* that it will get done that day, but it
seems likely.

It helps if you include your entire patch (and log message!) with each
reminder post. And if you've incorporated anyone's comments, for
example Philip Martin's, into the patch, then say so in the
introduction, so we know that reviewer X's feedback has been taken
care of.

Are you planning to repost the patch, or should we just use the last
copy we can find?

> if i wrote these 2 lines of code, and it worked, then i don't think
> it is using your spare time, or changes anything else in the tracked
> issues ...

Every patch we apply takes a certain minimum amount of time. We have
to read and understand it, and make sure it passes the regression
tests. It doesn't matter how trivial it is. I have applied patches
that did *nothing* except change the usage message for some option,
and it still broke a regression test (getopt_tests.py). Did you run
"make check" to make sure your patch passes, by the way?

Also, the priority developers give a patch is not necessarily related
to the size or complexity of the patch, as Mike Pilato explained.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Aug 25 23:15:58 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.