[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

svn_client_commit with empty targets array => coredump

From: Marcus Comstedt <marcus_at_mc.pp.se>
Date: 2002-08-24 15:19:11 CEST

I just noticed that calling svn_client_commit with an empty array for
the targets argument causes a core dump. The reason is that
svn_path_condense_targets() will set both base_dir and rel_targets to
NULL if the array is empty, and svn_client_commit() doesn't like this
at all. Which of the functions should be considered at fault here?
Is there any particular reason why svn_path_condense_targets() on an
empty array doesn't just set base_dir and rel_targets to the empty
string and an empty array respectively? Setting them to NULL seems to
compilcate the edge cases for no obvious benefit.

  // Marcus

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Aug 24 15:20:09 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.