Re: svn commit: rev 3032 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_client trunk/subversion/tests/clients/cmdline

On Thu, Aug 22, 2002 at 08:05:42PM -0500, cmpilato@tigris.org wrote:
> Author: cmpilato
> Date: 2002-08-22 20:05:37 -0500 (Thu, 22 Aug 2002)
> New Revision: 3032
>
> Modified:
> trunk/subversion/include/svn_wc.h
> trunk/subversion/libsvn_client/delete.c
> trunk/subversion/libsvn_client/status.c
> trunk/subversion/libsvn_wc/status.c
> trunk/subversion/tests/clients/cmdline/stat_tests.py
> Log:
> Fix some screwy `svn status' stuff. Tandem code-churnin' and
> bug-bustin' with Karl.

This log message doesn't say what was "screwy" and how you fixed it. The log
message simply goes through "added this param. removed this." It totally
misses the important question of "why?" There is a lot of what changed, but
no motivation, or how the end result now fixes the original problem.

I can review for code nits, but there is no way to review to ensure that you
actually changed it in a way to meet your goal.

>...
> +++ trunk/subversion/include/svn_wc.h Thu Aug 22 20:05:41 2002
>...
> + * If GET_ALL is unset, then only locally-modified entries will be
> + * returned. If set, then all entries will be returned.
>...
> + * If DESCEND is unset, statushash will contain statuses for PATH and
> + * its entries. Else if DESCEND is set, statushash will contain
> + * statuses for PATH and everything below it, including
> + * subdirectories. In other words, a full recursion. */

-1 on this change.

This is C code, not Perl. A variable is *always* set. Booleans are
true/false or non-zero/zero. But never ever "unset".

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org