[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn client UTF conversion errors

From: Brent R. Matzelle <bmatzelle_at_yahoo.com>
Date: 2002-08-23 04:00:07 CEST

--- Karl Fogel <kfogel@newton.ch.collab.net> wrote:
> "Brent R. Matzelle" <bmatzelle@yahoo.com> writes:
> > I looked into these issues and they are unrelated with rev 2805.
> The
> > UTF errors are just a red herring.
> >
> > It looks like svn_config__win_config_path should be setting a
> valid
> > home directory but since it does nothing the 'folder' variable is
> > filled with nonsense data. So then svn_io_check_path reads
> 'folder'
> > and sends that error message.
> I think the code is correct:
> The function svn_config__win_config_path() assumes the `folder'
> variable is a pre-allocated array, and writes directly into it. If
> SHGetFolderPathA() returns something other than S_OK, then none of
> svn_config__win_config_path()'s callers examine the contents of
> folder, they just return immediately.
> Is there a circumstance under which SHGetFolderPathA() can return
> S_OK, yet not touch its last arg (`folder')?
> (Anyway, if folder were really filled with garbage data, it's
> unlikely
> that we would be getting such a nice, clean error :-) ).

I figured out what the problem was.
svn_config__win_config_path() wouldn't compile for me because it was
missing the include that contains the constants and the
SHGetFolderPathA() function. I commented it out and forgot about it
weeks ago.

I just fixed the problem by including ShFolder.h and defining one
missing constant. I attached the patch that includes the changes to
config_win.c. I doubt it is the best way to go but it fixed my
problem so it might help somebody else.



Do You Yahoo!?
Yahoo! Finance - Get real-time stock quotes

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Fri Aug 23 04:00:48 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.