[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn client UTF conversion errors

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-08-22 23:34:50 CEST

"Brent R. Matzelle" <bmatzelle@yahoo.com> writes:
> I looked into these issues and they are unrelated with rev 2805. The
> UTF errors are just a red herring.
> It looks like svn_config__win_config_path should be setting a valid
> home directory but since it does nothing the 'folder' variable is
> filled with nonsense data. So then svn_io_check_path reads 'folder'
> and sends that error message.

I think the code is correct:

The function svn_config__win_config_path() assumes the `folder'
variable is a pre-allocated array, and writes directly into it. If
SHGetFolderPathA() returns something other than S_OK, then none of
svn_config__win_config_path()'s callers examine the contents of
folder, they just return immediately.

Is there a circumstance under which SHGetFolderPathA() can return
S_OK, yet not touch its last arg (`folder')?

(Anyway, if folder were really filled with garbage data, it's unlikely
that we would be getting such a nice, clean error :-) ).


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 22 23:53:24 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.