[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 3027 - trunk/subversion/svnadmin trunk/subversion/clients/cmdline

From: Branko Čibej <brane_at_xbc.nu>
Date: 2002-08-23 01:55:52 CEST

Blair Zajac wrote:

>Branko ?ibej wrote:
>
>
>>blair@tigris.org wrote:
>>
>>
>>
>>>Author: blair
>>>Date: 2002-08-22 17:49:46 -0500 (Thu, 22 Aug 2002)
>>>New Revision: 3027
>>>
>>>Modified:
>>> trunk/subversion/clients/cmdline/subversion_client.dsp
>>> trunk/subversion/svnadmin/svnadmin.dsp
>>>Log:
>>>Fixes to enable compiling the svn and svnadmin resource files with
>>>Microsoft Visual Studio.net. It seems that the parser that reads the
>>>*.dsp files and converts them to *.vcproj files cannot handle "'s in
>>>the middle of strings. So instead of quoting like this:
>>>
>>> ..... /d SVN_FILE_DESCRIPTION="Subversion Client"
>>>
>>>make sure to quote like this:
>>>
>>> ..... /d "SVN_FILE_DESCRIPTION=Subversion Client"
>>>
>>>In our case, it misparses the resource compiler options and passes /d
>>>"SVN_FILE_DESCRIPTION="Subversion Client"" to cmd.exe and on to
>>>rc.exe, which prints a "RC : fatal error RC1107 : invalid usage; use
>>>RC /? for Help" message.
>>>
>>>
>>>
>>>
>>This change breaks the VC6.0 build, with the same error you describe
>>here. Please revert it.
>>
>>
>
>How about a compromise that works for both compilers. We remove all
>the quotes and s/ /_/g on the define's value. Not pretty, but simple
>for now until the .dsp and .vcproj file generators are written.
>
>

O.K., I'll buy that:

  "Subversion Client" --> Subversion_Client
  "Subversion Repository Administrator" --> Subversion_Repository_Administrator
  "Subversion Repository Browser" --> Subversion_Repository_Browser

And please create a new issue about this, dependent on #850, so that we
don't forget it.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Aug 23 01:56:39 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.