[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Entries caching?

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2002-08-11 20:21:46 CEST

Justin Erenkrantz <jerenkrantz@apache.org> writes:

> Well, we seem to be coming back to this in other threads.
> What would we like to do about entries caching?
> - Fix libsvn_wc in one swoop to correctly pass the admin_baton
> everywhere.
> Status: Posted an incomplete broken patch that starts the
> conversion process.
> Pro: Everything gets fixed.
> Con: I don't have the time to complete this, so this would have to
> fall to someone else.
> - Branch off and commit the broken patch.
> Pro: If someone steps up, they can pick up the pieces.
> Con: Unlikely to work and I can't see the branch through anyway,
> so the branch is likely to get out-of-date quickly.
> - Add a caching-only API
> Status: Patches posted (if what I posted before doesn't cleanly
> apply, it'd be fairly easy to make it clean again).
> Pro: Allows us to incrementally address the API concerns without
> forcing to change the entirety of libsvn_wc.
> Con: Philip has stated he is very much against this. I believe he
> may have even vetoed this.
> I'd like to see the caching hit before 1.0, but since I have a life
> outside of SVN, I just can not devote the time to change all of
> libsvn_wc. Everytime I try to put aside time to it, I just cry when
> I look at it. In the limited time I have, I'd like to address more
> attainable goals (such as getting svn-config to work properly when
> we have in-tree dependencies).
> Thoughts? -- justin

I have another patch for 749; it passes the access baton to
svn_wc__entry_modify. It touches quite a lot of functions as you can
imagine :-) It passes the regression tests, and has done so for a few
days now, but other things keep breaking. The issue 838 patch broke
it, and to a lesser degree the recent URL keyword patch. My patch also
uncoverered some path canonicalization bugs that I have since fixed.

The patch is just about ready to go, I'm just looking at a final
revert problem (svn_wc_revert is not nice, it's nearly as bad as
svn_wc_add). It's not a case covered by the regression tests.

If you wait until this patch gets applied you may well find caching
much easier.

Philip Martin
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Aug 11 20:22:22 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.