Re: svn commit: rev 2821 - trunk/subversion/libsvn_wc trunk/subversion/clients/cmdline trunk/subversion/tests/clients/cmdline

Philip Martin <philip@codematters.co.uk> writes:
> The last problem I saw was when running 'svn ci .'
>
> svn_path_condense_targets calls svn_path_get_absolute passing "." and
> gets back a path with a trailing slash, something like "/home/pm/wc/".
> Now if the command is 'svn ci /home/pm/wc/', or 'svn ci /home/pm/wc',
> then svn_path_get_absolute returns "/home/pm/wc" without a slash.
>
> So should a working copy directory path include a trailing slash?

Hmmm. Euuuuww.

Could we just change the definition of canonicalized path to mean
"without trailing slash if directory", and change the code
(condense_targets and friends) accordingly? Does anything depend on
this?

> The locking code uses the path as a hash key. So if the trailing
> slash is optional the code needs to ensure that setting and getting
> will work both with and without the trailing slash.

Gotcha. Sorry for the mess you're inheriting here...

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 1 23:28:50 2002