[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: EINVAL vs APR_EINVAL in apr_xlate_open()

From: Justin Erenkrantz <jerenkrantz_at_apache.org>
Date: 2002-07-19 00:20:03 CEST

On Thu, Jul 18, 2002 at 05:04:33PM -0500, Karl Fogel wrote:
> Well, this is *us* generating the EINVAL by fiat, not getting it from
> some lower-down system call.
> Maybe we should still go with APR_EINVAL, on the principle of least
> surprise, though. I'm not sure; trusting people with more APR
> experience to know a good answer here.

Right, the system is free to use EINVAL. APR should not produce
EINVAL itself.

I'm assuming you mean this code fragment in xlate.c:

return rv ? rv : EINVAL;

By all means that should be:

return rv ? rv : APR_EINVAL;

HTH. -- justin

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 19 00:20:46 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.