[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2581 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_subr trunk/subversion/libsvn_client

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-07-18 22:11:49 CEST

On Thu, Jul 18, 2002 at 02:45:32PM -0500, cmpilato@tigris.org wrote:
>...
> Log:
> * subversion/include/svn_path.h
> * subversion/libsvn_subr/path.c
> (svn_path_url_add_component): New.

Oh, bleck. Within URL terminology, they are *segments*, which is why I used
that specific term in my comment.

I also do not see why the "path" is in there. You're talking about URLs at
this point, so svn_url_* seems a much more appropriate prefix. svn_path_url
just seems a bit overmuch. Was that because this happens to live in
svn_path.h rather than, say, svn_uri.h ?

Hmm. Maybe all of our svn_path_uri_* should be apr_uri_*, living in
apr-util.

Thoughts?

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 18 22:09:54 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.