Re: svn commit: rev 2581 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_subr trunk/subversion/libsvn_client

Greg Stein <gstein@lyra.org> writes:

> On Thu, Jul 18, 2002 at 02:45:32PM -0500, cmpilato@tigris.org wrote:
> >...
> > Log:
> > * subversion/include/svn_path.h
> > * subversion/libsvn_subr/path.c
> > (svn_path_url_add_component): New.
>
> Oh, bleck. Within URL terminology, they are *segments*, which is why I used
> that specific term in my comment.

Oh. Didn't realize that. Ignorance + desire for consistency with
other path-y function names = svn_path_url_add_component.

> I also do not see why the "path" is in there. You're talking about URLs at
> this point, so svn_url_* seems a much more appropriate prefix. svn_path_url
> just seems a bit overmuch. Was that because this happens to live in
> svn_path.h rather than, say, svn_uri.h ?

That's the very reason.

> Hmm. Maybe all of our svn_path_uri_* should be apr_uri_*, living in
> apr-util.

As noted in another mail, that means we started talking about path
structures, which I think would be annoying.

Unless you mean you just want to move the const char * stuff into APR
(which I think would be wonderful).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 18 23:31:16 2002