Re: svn commit: rev 2581 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_subr trunk/subversion/libsvn_client

On Thu, Jul 18, 2002 at 01:11:49PM -0700, Greg Stein wrote:
> On Thu, Jul 18, 2002 at 02:45:32PM -0500, cmpilato@tigris.org wrote:
> >...
> > Log:
> > * subversion/include/svn_path.h
> > * subversion/libsvn_subr/path.c
> > (svn_path_url_add_component): New.
>
> Oh, bleck. Within URL terminology, they are *segments*, which is why I used
> that specific term in my comment.
>
> I also do not see why the "path" is in there. You're talking about URLs at
> this point, so svn_url_* seems a much more appropriate prefix. svn_path_url
> just seems a bit overmuch. Was that because this happens to live in
> svn_path.h rather than, say, svn_uri.h ?
>
>
> Hmm. Maybe all of our svn_path_uri_* should be apr_uri_*, living in
> apr-util.

apr-util has what seems to be a reasonable uri library, so i'd be +1
on using it/extending it with stuff we need instead of writing out own
if it's feasable.

-garrett

-- 
garrett rooney                    Remember, any design flaw you're 
rooneg@electricjellyfish.net      sufficiently snide about becomes  
http://electricjellyfish.net/     a feature.       -- Dan Sugalski
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org