Re: [PATCH] Store remote host ip on commit

On Wed, Jul 17, 2002 at 05:38:53PM -0500, Ben Collins-Sussman wrote:
> Peter Schuller <peter.schuller@infidyne.com> writes:
> > > So I both wonder whether this information is useful, and even if it
> > > is, whether it always applies or can be reliably obtained... as you
> > > acknowledge in this paragraph:
> >
> > As a user, I think it is a good idea. In case of abuse, the IP of the
> > person doing the commits is logged. Without any form av IP logging, it
> > would be impossible to tell who did it without logging all TCP
> > connetions to the host (assuming the password got out somehow and the
> > person responsible for the account is innocent).
> >
> > IMO it's just a nice thing to have...
>
> I don't get it; isn't apache already logging the IP address of every
> request in its access_log? Isn't that enough?

Exactly. Just search your access_log for each use of MERGE (which
corresponds to the final step of a commit).

While it is kind of neat, I don't see a lot of purpose to it.

However, I *do* think it would be nice to pass some of this information to
the hook scripts (it is quite probably that the hook script wants to include
the remote host/ip in some kind of logging, email, or other transaction). I
believe this should be doable by passing a lot of the information via the
environment, much like CGI passes data.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org