[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Store remote host ip on commit

From: Brian Behlendorf <brian_at_collab.net>
Date: 2002-07-18 02:46:46 CEST

On Wed, 17 Jul 2002, Greg Stein wrote:
> On Wed, Jul 17, 2002 at 05:38:53PM -0500, Ben Collins-Sussman wrote:
> >
> > I don't get it; isn't apache already logging the IP address of every
> > request in its access_log? Isn't that enough?
>
> Exactly. Just search your access_log for each use of MERGE (which
> corresponds to the final step of a commit).

I kind of like it. Access logs are so voluminous that people rarely keep
them for much longer than a few months. You could tell them to grep MERGE
from the logs and just keep that, I suppose. But usually when people
realize they could use that IP address ("Hey, this commit says it was from
me, but I didn't do it! Where did that come from? Who has my password?")
they also haven't been keeping MERGE logs. I dunno, I don't feel strongly
about it, but I can see non-fringe use cases for it where log files might
not always suffice.

Oh yeah, log files are usually the sole perogative of admins running the
servers, whereas this way anyone could get that data without having to ask
the keepers of the logs. Greg, I'd have expected the # of times you have
to go through CollabNet "ops" for data about CVS to have motivated you to
open up data to end-users whenever possible. :)

        Brian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 18 02:47:11 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.