Re: svn commit: rev 2521 - trunk/subversion/libsvn_client

Philip Martin <philip@codematters.co.uk> writes:
> Or it reveals a philosophical bug in the old commit system, it depends
> on your point of view :)

Oh, absolutely! I think there's no disagreement there.

> Post-commit processing requires more locks than pre-commit processing.
> This is not a good idea, as the commit might suceed on the server and
> fail in svn_wc_process_committed due to a lock left over from a
> previous command that failed. I think that *all* the required locks
> should be acquired before starting a commit, and then
> svn_wc_process_committed should simply use its given locks, and not
> take new ones.

Yep. Ben's reviewing your latest patch; if we can apply that rather
than revert, we will. It might still be feasible to get forward
motion into Alpha...

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 15 20:43:34 2002