[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2485 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_client

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-07-12 18:13:56 CEST

kevin@tigris.org writes:
> This means that we will get an error if 'svn:executable' is set, edited, or
> deleted from a directory in the non-recursive case. In the recursive case
> directories will be silently ignored, and the operation will be performed on
> the files only. Is this behaviour acceptable to everyone?

Why would we prohibit deletions? Then our "good" client can't even
repair lossage caused by "bad" clients... :-)

If the policy is that the property is not allowed on dirs, then we
should allow removing it from dirs where it already exists, IMHO.

> Modified: trunk/subversion/libsvn_client/prop_commands.c
> ==============================================================================
> --- trunk/subversion/libsvn_client/prop_commands.c (original)
> +++ trunk/subversion/libsvn_client/prop_commands.c Fri Jul 12 10:47:16 2002
> if (current_entry->kind == svn_node_dir && current_entry_name)

Gack. I know this isn't your code, but we should parenthesize this
for clear precedence. (Clear to humans, I mean.)

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 12 18:25:01 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.