[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2471 - trunk/subversion/libsvn_wc

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-07-12 05:48:40 CEST

Greg Stein <gstein@lyra.org> writes:
> > * subversion/libsvn_wc/diff.c
> > (directory_elements_diff): Remove an unnecessary call to
> > svn_pool_destroy.
>
> Euh... that is inside of an unbounded loop. Thus, you could end up filling
> dir_baton->pool with a ton of stuff. In this case, I think that leaving the
> pool destruction is better than tossing it (since you don't have an
> iteration subpool).

Huh? It does have an iteration subpool... (?)

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 12 05:59:32 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.