Re: svn commit: rev 2471 - trunk/subversion/libsvn_wc

On Thu, Jul 11, 2002 at 10:48:40PM -0500, Karl Fogel wrote:
> Greg Stein <gstein@lyra.org> writes:
> > > * subversion/libsvn_wc/diff.c
> > > (directory_elements_diff): Remove an unnecessary call to
> > > svn_pool_destroy.
> >
> > Euh... that is inside of an unbounded loop. Thus, you could end up filling
> > dir_baton->pool with a ton of stuff. In this case, I think that leaving the
> > pool destruction is better than tossing it (since you don't have an
> > iteration subpool).
>
> Huh? It does have an iteration subpool... (?)

Oh, crap. I was looking at an older version of the file. Never mind...

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org