[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2471 - trunk/subversion/libsvn_wc

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-07-12 01:11:46 CEST

On Thu, Jul 11, 2002 at 05:16:14PM -0500, kfogel@tigris.org wrote:
> Author: kfogel
> Date: Thu, 11 Jul 2002 17:15:56 -0500
> New Revision: 2471
> Modified:
> trunk/subversion/libsvn_wc/diff.c
> Log:
> * subversion/libsvn_wc/diff.c
> (directory_elements_diff): Remove an unnecessary call to
> svn_pool_destroy.

Euh... that is inside of an unbounded loop. Thus, you could end up filling
dir_baton->pool with a ton of stuff. In this case, I think that leaving the
pool destruction is better than tossing it (since you don't have an
iteration subpool).

> I think there are other questionable pool creation/destruction
> patterns going on in this file, but not as localized as this one, so
> I've left them for the nonce.

The whole file is using an old-style editor. It needs to be converted, and
appropriate pool usage used in the loops.


Greg Stein, http://www.lyra.org/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 12 01:10:20 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.