Karl Fogel <kfogel@newton.ch.collab.net> writes:
> Marcus, as you can see, rev 2388 applies a portion of your patch. I'm
Yay!
> doing it in stages, to make it reviewable and also because smaller
> changes are less likely to be destabilizing. The patch is excellent
> overall, and your log message was completely indispensable. Thanks
> for doing such a thorough job!
>
> I made only minor tweaks to the stuff in this commit, which I'll point
> out below in the interests of prompt feedback:
>
> > +svn_error_t *
> > +svn_io_dir_read (apr_finfo_t *finfo,
> > + apr_int32_t wanted,
> > + apr_dir_t *thedir,
> > + apr_pool_t *pool)
> > +{
> > + apr_status_t status;
> > +
> > + status = apr_dir_read (finfo, wanted, thedir);
> > +
> > + if (status)
> > + return svn_error_create (status, 0, NULL, pool,
> > + "error reading directory");
> > +
> > + return SVN_NO_ERROR;
> > +}
>
> Note that this version of svn_io_dir_read() just takes a pool, instead
> of doing that ultra-backdoor cast you had in your patch :-).
Ok. The only reason I didn't want to take a pool argument was that I
wanted the prototype to be exactly the same as for apr_dir_read.
Which it isn't anyway due to having a different return type... Carry
on. :-)
> > - /* ### this cast is a kluge */
> > - SVN_ERR (svn_path_get_absolute ((char **) pbasedir,
> > + SVN_ERR (svn_path_get_absolute (pbasedir,
> > ((const char **) targets->elts)[0],
> > pool));
>
> Your patch got rid of the casts, but didn't get rid of the comments
> complaining about the casts. I took out the comments too (I remember
> writing some of them, nice to see them go finally!).
Right. Wasn't 100% sure which of the two casts that was being referred to.
> That's basically it. Thanks for all your work, watch to see more of
> it committed over the next couple of days.
Um, ok. That's two changes in 150K of patches. :-) I'll go throgh
the details of the checkins later, in case there are any.
Sorry about the lack of "prompt feedback" on my behalf, I've just
returned from a week on the countryside without internet access. ^.^;
// Marcus
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 9 17:29:11 2002