[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

started applying Marcus' patch

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-07-02 00:28:22 CEST

Marcus, as you can see, rev 2388 applies a portion of your patch. I'm
doing it in stages, to make it reviewable and also because smaller
changes are less likely to be destabilizing. The patch is excellent
overall, and your log message was completely indispensable. Thanks
for doing such a thorough job!

I made only minor tweaks to the stuff in this commit, which I'll point
out below in the interests of prompt feedback:

> +svn_error_t *
> +svn_io_dir_read (apr_finfo_t *finfo,
> + apr_int32_t wanted,
> + apr_dir_t *thedir,
> + apr_pool_t *pool)
> +{
> + apr_status_t status;
> +
> + status = apr_dir_read (finfo, wanted, thedir);
> +
> + if (status)
> + return svn_error_create (status, 0, NULL, pool,
> + "error reading directory");
> +
> + return SVN_NO_ERROR;
> +}

Note that this version of svn_io_dir_read() just takes a pool, instead
of doing that ultra-backdoor cast you had in your patch :-).

(Also, the UTF-8 code isn't in there, as I'm sure you noticed, but the
log message for my commit explains what's going on with that).

> - /* ### this cast is a kluge */
> - SVN_ERR (svn_path_get_absolute ((char **) pbasedir,
> + SVN_ERR (svn_path_get_absolute (pbasedir,
> ((const char **) targets->elts)[0],
> pool));

Your patch got rid of the casts, but didn't get rid of the comments
complaining about the casts. I took out the comments too (I remember
writing some of them, nice to see them go finally!).

That's basically it. Thanks for all your work, watch to see more of
it committed over the next couple of days.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 2 00:37:37 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.