[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: started applying Marcus' patch

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-07-09 20:43:35 CEST

Marcus Comstedt <marcus@mc.pp.se> writes:
> Um, ok. That's two changes in 150K of patches. :-) I'll go throgh
> the details of the checkins later, in case there are any.

Note that I did make a fair number of other tweaks to your patch in my
commit of rev 2428. Since I wanted to commit one reviewable entity,
rather than doing it in two steps, unfortunately for you this made it
hard to see how I changed your patch (i.e., you didn't get the diff to
your diff).

Mike Pilato is doing it the other way right now, somewhat
serendipitously -- he assumed that I had already reviewed your client
patch, so he just applied it and committed. Now he's aware that it
was unreviewed, so he's reviewing and will commit the tweaks
separately. This is a bit rockier for the project as a whole, but
much better for you, since now you'll actually see the changes made to
your patch as a separate commit (or commits).

None of which is to say that the patch was bad, of course! In
anything that size, there are going to be a few problems. Overall,
this patch was exactly what Subversion needed -- just wanted to make
it clear that it's not only two changes in 150K :-).

> Sorry about the lack of "prompt feedback" on my behalf, I've just
> returned from a week on the countryside without internet access. ^.^;

I'm jealous :-).


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 9 20:54:09 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.