[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] httpd discards body too soon

From: Justin Erenkrantz <jerenkrantz_at_apache.org>
Date: 2002-06-26 01:14:00 CEST

On Tue, Jun 25, 2002 at 03:55:52PM -0700, Greg Stein wrote:
> What do you think of the tri-state solution?
> It *does* mean that we might discard a body, but then later find out we
> didn't need to. However, it would remove an accidental non-discard.

That'd work. I believe there are some modules that are expecting
that 0 is closed.

Hmm. Oh, joy:

/** Are we going to keep the connection alive for another request?
 * -1 fatal error, 0 undecided, 1 yes */
signed int keepalive:2;

Sounds like we just need an explicit no here. Or, we can use the
-1 to mean 'no.' However, a lot of places are using 0 for no -
that behavior looks incorrect. -- justin

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 26 01:14:44 2002

This is an archived mail posted to the Subversion Dev mailing list.