Re: [PATCH] httpd discards body too soon

On Tue, Jun 25, 2002 at 04:14:00PM -0700, Justin Erenkrantz wrote:
> On Tue, Jun 25, 2002 at 03:55:52PM -0700, Greg Stein wrote:
> > What do you think of the tri-state solution?
> >
> > It *does* mean that we might discard a body, but then later find out we
> > didn't need to. However, it would remove an accidental non-discard.
>
> That'd work. I believe there are some modules that are expecting
> that 0 is closed.
>
> Hmm. Oh, joy:
>
> /** Are we going to keep the connection alive for another request?
> * -1 fatal error, 0 undecided, 1 yes */
> signed int keepalive:2;
>
> Sounds like we just need an explicit no here. Or, we can use the
> -1 to mean 'no.' However, a lot of places are using 0 for no -
> that behavior looks incorrect. -- justin

I say, axe the darned bitfield. That is no 80's. Replace the keepalive flag
with an explicit enumeration.

No more magic constants!

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org