[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] httpd discards body too soon

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-06-26 00:55:52 CEST

On Tue, Jun 25, 2002 at 03:21:29PM -0700, Justin Erenkrantz wrote:
> Okay, the problem is that ap_discard_request_body now checks the
> keepalive status of the connection (correctly defaults to 0 which
> means that ap_discard_request_body never discards requests).

I'm not sure that "correctly defaults to 0" is truly correct. It seems that
we would want a tri-state value for that variable: unknown, connection-
closes, and connection-stays-open.

This would have solved the problem at hand because the value would have been
"unknown", so the discard would have happened.

> This is a temporary fix, as I think we need to rethink checking the
> connection status in ap_discard_request_body since the connection
> status is only set once ap_http_header_filter is involved. This
> pretty much invalidates calling ap_discard_request_body() anywhere
> except once we know the EOS is sent. -- justin

What do you think of the tri-state solution?

It *does* mean that we might discard a body, but then later find out we
didn't need to. However, it would remove an accidental non-discard.


Greg Stein, http://www.lyra.org/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 26 00:53:34 2002

This is an archived mail posted to the Subversion Dev mailing list.