Re: svn commit: rev 2186 - trunk/subversion/svnadmin

Branko Čibej <brane@xbc.nu> writes:

> The issue about APR_BINARY being ignored is totally orthogonal and has
> nothing to do with this problem, as I've pointed out elsewhere.

Sorry, my muddled mind misunderstood the issues. I've fixed the comment.

> static svn_error_t *
> create_stdio_stream (svn_stream_t **stream,
> apr_status_t open_fn (apr_file_t **, apr_pool_t *),
> apr_pool_t *pool)

Great! Much simpler! I've changed it.

> >-
> >- fflush(stdout);
> >
> Are you sure we don't need the flush?
> (I don't know, it might be safer to keep it. If we do, it might make
> sense to add a flush handler to the svn streams.)

While it might be nice to add flush handlers to svn streams in
general, I think it's safe to remove this flush. I mean, as soon as
svn_repos_dump_fs() finishes, the whole program exits. Doesn't that
automatically flush stdout?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 13 21:48:16 2002