Re: svn commit: rev 2186 - trunk/subversion/svnadmin

On Thu, Jun 13, 2002 at 02:46:02PM -0500, Ben Collins-Sussman wrote:
> Branko Cibej <brane@xbc.nu> writes:
>...
> > >-
> > >- fflush(stdout);
> >
> > Are you sure we don't need the flush?
> > (I don't know, it might be safer to keep it. If we do, it might make
> > sense to add a flush handler to the svn streams.)
>
> While it might be nice to add flush handlers to svn streams in
> general, I think it's safe to remove this flush. I mean, as soon as
> svn_repos_dump_fs() finishes, the whole program exits. Doesn't that
> automatically flush stdout?

Yes, it will flush stdout.

(I considered the same when I reviewed the code; didn't have an immediate
suggestion for the enum wonkiness, and Branko's idea was great)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org